Skip to content

Complete Coding 2 #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mgpadshala wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete Coding 2 #1149

mgpadshala wants to merge 1 commit into from

Conversation

@mgpadshala
Copy link

@mgpadshala mgpadshala commented Dec 1, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Dec 1, 2025

  • Strengths:
    • The student demonstrates a strong understanding of both problems and provides multiple approaches for the knapsack problem.
    • The code is well-documented and easy to follow.
    • The student has chosen optimal solutions for both problems, showing good problem-solving skills.
  • Areas for Improvement:
    • For the twoSum problem, the student could mention that the hash map approach assumes there is exactly one solution, which is guaranteed by the problem statement. This could be clarified in the comments.
    • The knapsack problem could benefit from a brief explanation of why the 1D DP solution is optimal in terms of space complexity, as the student has done for time complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgpadshala @super30admin